[llvm] r348350 - Remove superfluous comments. NFCI.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 03:10:42 PST 2018


Diff looks odd, what happened here?

On Wed, Dec 5, 2018 at 11:48 AM Simon Pilgrim via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rksimon
> Date: Wed Dec  5 02:45:44 2018
> New Revision: 348350
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348350&view=rev
> Log:
> Remove superfluous comments. NFCI.
>
> As requested in D54698.
>
> Modified:
>     llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp?rev=348350&r1=348349&r2=348350&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp Wed Dec  5
> 02:45:44 2018
> @@ -129,12 +129,12 @@ class VectorLegalizer {
>    SDValue ExpandFNEG(SDValue Op);
>    SDValue ExpandFSUB(SDValue Op);
>    SDValue ExpandBITREVERSE(SDValue Op);
> -  SDValue ExpandCTPOP(SDValue Op);
> -  SDValue ExpandCTLZ(SDValue Op);
> -  SDValue ExpandCTTZ(SDValue Op);
> -  SDValue ExpandFMINNUM_FMAXNUM(SDValue Op);
> -  SDValue ExpandStrictFPOp(SDValue Op);
> -
> +  SDValue ExpandCTPOP(SDValue Op);
> +  SDValue ExpandCTLZ(SDValue Op);
> +  SDValue ExpandCTTZ(SDValue Op);
> +  SDValue ExpandFMINNUM_FMAXNUM(SDValue Op);
> +  SDValue ExpandStrictFPOp(SDValue Op);
> +
>    /// Implements vector promotion.
>    ///
>    /// This is essentially just bitcasting the operands to a different
> type and
> @@ -746,12 +746,12 @@ SDValue VectorLegalizer::Expand(SDValue
>    case ISD::CTLZ:
>    case ISD::CTLZ_ZERO_UNDEF:
>      return ExpandCTLZ(Op);
> -  case ISD::CTTZ:
> -  case ISD::CTTZ_ZERO_UNDEF:
> -    return ExpandCTTZ(Op);
> -  case ISD::FMINNUM:
> -  case ISD::FMAXNUM:
> -    return ExpandFMINNUM_FMAXNUM(Op);
> +  case ISD::CTTZ:
> +  case ISD::CTTZ_ZERO_UNDEF:
> +    return ExpandCTTZ(Op);
> +  case ISD::FMINNUM:
> +  case ISD::FMAXNUM:
> +    return ExpandFMINNUM_FMAXNUM(Op);
>    case ISD::STRICT_FADD:
>    case ISD::STRICT_FSUB:
>    case ISD::STRICT_FMUL:
> @@ -1123,38 +1123,32 @@ SDValue VectorLegalizer::ExpandFSUB(SDVa
>      return Op; // Defer to LegalizeDAG
>
>    return DAG.UnrollVectorOp(Op.getNode());
> -}
> -
> -SDValue VectorLegalizer::ExpandCTPOP(SDValue Op) {
> -  // Attempt to expand using TargetLowering.
> -  SDValue Result;
> -  if (TLI.expandCTPOP(Op.getNode(), Result, DAG))
> -    return Result;
> -
> -  // Otherwise go ahead and unroll.
> -  return DAG.UnrollVectorOp(Op.getNode());
> -}
> -
> -SDValue VectorLegalizer::ExpandCTLZ(SDValue Op) {
> -  // Attempt to expand using TargetLowering.
> -  SDValue Result;
> -  if (TLI.expandCTLZ(Op.getNode(), Result, DAG))
> -    return Result;
> -
> -  // Otherwise go ahead and unroll.
> -  return DAG.UnrollVectorOp(Op.getNode());
> -}
> -
> -SDValue VectorLegalizer::ExpandCTTZ(SDValue Op) {
> -  // Attempt to expand using TargetLowering.
> -  SDValue Result;
> -  if (TLI.expandCTTZ(Op.getNode(), Result, DAG))
> -    return Result;
> -
> -  // Otherwise go ahead and unroll.
> -  return DAG.UnrollVectorOp(Op.getNode());
> -}
> -
> +}
> +
> +SDValue VectorLegalizer::ExpandCTPOP(SDValue Op) {
> +  SDValue Result;
> +  if (TLI.expandCTPOP(Op.getNode(), Result, DAG))
> +    return Result;
> +
> +  return DAG.UnrollVectorOp(Op.getNode());
> +}
> +
> +SDValue VectorLegalizer::ExpandCTLZ(SDValue Op) {
> +  SDValue Result;
> +  if (TLI.expandCTLZ(Op.getNode(), Result, DAG))
> +    return Result;
> +
> +  return DAG.UnrollVectorOp(Op.getNode());
> +}
> +
> +SDValue VectorLegalizer::ExpandCTTZ(SDValue Op) {
> +  SDValue Result;
> +  if (TLI.expandCTTZ(Op.getNode(), Result, DAG))
> +    return Result;
> +
> +  return DAG.UnrollVectorOp(Op.getNode());
> +}
> +
>  SDValue VectorLegalizer::ExpandFMINNUM_FMAXNUM(SDValue Op) {
>    if (SDValue Expanded = TLI.expandFMINNUM_FMAXNUM(Op.getNode(), DAG))
>      return Expanded;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181205/bba34904/attachment.html>


More information about the llvm-commits mailing list