[PATCH] D55019: Add a new interceptor for fparseln(3) from NetBSD
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 5 01:50:30 PST 2018
vitalybuka added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7365
+ COMMON_INTERCEPTOR_WRITE_RANGE(ctx, len, sizeof(*len));
+ if (lineno)
+ COMMON_INTERCEPTOR_WRITE_RANGE(ctx, lineno, sizeof(*lineno));
----------------
maybe unpoison_file?
================
Comment at: test/sanitizer_common/TestCases/NetBSD/fparseln.cc:10
+ char *line;
+ size_t len, lineno;
+ int flags;
----------------
would be nice to keep declarations close to use
and use asserts
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55019/new/
https://reviews.llvm.org/D55019
More information about the llvm-commits
mailing list