[PATCH] D55266: [LICM] Use per-block hoist points when rehoisting instructions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 19:51:13 PST 2018


mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:810
                         << *I << "\n");
-      if (!HoistPoint || HoistPoint->getParent() != Dominator) {
-        if (HoistPoint)
----------------
If we replace `HoistPoint->getParent() != Dominator` with ` DT->dominates(Dominator, HoistPoint->getParent())`, will it solve your problem?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55266/new/

https://reviews.llvm.org/D55266





More information about the llvm-commits mailing list