[PATCH] D55303: [RISCV, WIP] Add lowering of addressing sequences for PIC

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 19:03:56 PST 2018


jrtc27 requested changes to this revision.
jrtc27 added a comment.
This revision now requires changes to proceed.

Half of this (the MC side of the GOT modifier) is already proposed in D55279 <https://reviews.llvm.org/D55279>. Also note that the assembly modifier is not `%got_hi` but `%got_pcrel_hi` after a discussion with upstream (check the assembler manual) to clearly convey that it's a PC-relative relocation to the GOT entry rather than generating a GOT index as would be the case on some older architectures. I did however, like you, use `GOT_HI` in the various LLVM-internal enumeration entries to match the name of the relocation.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55303/new/

https://reviews.llvm.org/D55303





More information about the llvm-commits mailing list