[PATCH] D55290: [docs] Update llvm.loop metadata documentation.
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 4 16:58:41 PST 2018
Meinersbur marked 2 inline comments as done.
Meinersbur added inline comments.
================
Comment at: docs/LangRef.rst:5100
+reference to itself. It was used to avoid collapsing of multiple loop
+metadata nodes into one. The use of 'distinct' metadata nodes is also
+obsolete.
----------------
hfinkel wrote:
> Meinersbur wrote:
> > hfinkel wrote:
> > > Really? Why is it obsolete? (in any case, if that's true, it should be mentioned elsewhere in the LangRef).
> > Obsolete only for use in llvm.loop metadata, not in general. How about this wording?
> >
> > The 'distinct' keyword for loop metadata is also not necessary anymore.
> Then why add it to the example?
>
> I'd say:
>
> Also, the 'distinct' keyword for loop-metadata nodes is no longer necessary.
>
> Then why add it to the example?
The idea was, because clang currently generates it.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55290/new/
https://reviews.llvm.org/D55290
More information about the llvm-commits
mailing list