[PATCH] D55073: [SelectionDAG] Split very large token factors for loads into 64k chunks

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 16:33:56 PST 2018


aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:9027
+  assert(1 << (sizeof(SDNode::NumOperands) * 8) > Vals.size() &&
+         "too many operands to fit into SDNode");
   SDUse *Ops = OperandRecycler.allocate(
----------------
efriedma wrote:
> Maybe this would be more readable using std::numeric_limits?  Your choice.
Sure.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55073/new/

https://reviews.llvm.org/D55073





More information about the llvm-commits mailing list