[PATCH] D55248: [ELF] Simplify getSectionPiece

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 14:26:57 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/InputSection.cpp:1230
+      });
+  assert(Pieces[0].InputOff == 0 && It2 != Pieces.begin());
+  return &It2[-1];
----------------
You can remove this `assert` as it doesn't make much sense anymore.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55248/new/

https://reviews.llvm.org/D55248





More information about the llvm-commits mailing list