[PATCH] D55234: Do not use a hash table to uniquify mergeable strings.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 4 10:36:30 PST 2018
grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
In D55234#1318900 <https://reviews.llvm.org/D55234#1318900>, @ruiu wrote:
> What we should and do actually care about are programs whose size is multi-gibibyte that take 30 seconds to a few minutes to link. Unfortunately I cannot share the programs with you, but we observed both speedup and memory usage reduction with this patch.
Well, that sounds like an argument I can't resist. I do not have such apps underhand for testing,
so if you observe the stable improvements you're happy with, then LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55234/new/
https://reviews.llvm.org/D55234
More information about the llvm-commits
mailing list