[PATCH] D55271: [test] Split strip-preserve-time.test, and skip atime test on NetBSD

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, with a couple of nits.



================
Comment at: test/tools/llvm-objcopy/ELF/strip-preserve-atime.test:52
 # CHECK-PRESERVE-ATIME:        {{[[:space:]]1995}}
 # CHECK-PRESERVE-MTIME:        {{[[:space:]]1997}}
 
----------------
You should delete and it's corresponding NO-PRESERVE, since it's unused.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test:50
 
 # CHECK-PRESERVE-ATIME:        {{[[:space:]]1995}}
 # CHECK-PRESERVE-MTIME:        {{[[:space:]]1997}}
----------------
Same comment as in the other test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55271/new/

https://reviews.llvm.org/D55271