[PATCH] D54698: [SelectionDAG] Initial support for FSHL/FSHR funnel shift opcodes (PR39467)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 00:11:58 PST 2018


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/funnel-shift.ll:340
 
 ; Check modulo math on shift amount. 41-32=9, but right-shift became left, so 32-9=23.
 
----------------
spatel wrote:
> Update test comment? Do you know why we got opposite directions here?
It looks like the shldl is commuted during regalloc.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54698/new/

https://reviews.llvm.org/D54698





More information about the llvm-commits mailing list