[PATCH] D55102: [MachineLICM][X86][AMDGPU] Fix subtle bug in the updating of PhysRegClobbers in post-RA LICM

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: lib/CodeGen/MachineLICM.cpp:460
 
     // If we have already seen another instruction that defines the same
     // register, then this is not safe.  Two defs is indicated by setting a
----------------
arsenm wrote:
> Can all of this code be converted to look at RegUnits instead of using MCRegAliasIterator?
Maybe. I'm not very familiar with RegUnits. Maybe we can look at that as a follow up if this change is ok by itself?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55102/new/

https://reviews.llvm.org/D55102