[PATCH] D55216: [bugpoint][PR29027] Reduce function attributes

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Looks like a good step in the right direction after some cleanup.  Any chance you're interested in doing the same for argument or return attributes?



================
Comment at: test/BugPoint/func-attrs.ll:6
+; CHECK: f() #0
+define void @f() #0 {
+  ret void
----------------
Can you add an example which uses key=value for the crashing attribute to show that works?  "bugpoint-crash"="blah" should work fine.


================
Comment at: test/BugPoint/func-attrs.ll:11
+; CHECK: "bugpoint-crash"
+; CHECK-NOT: inline
+attributes #0 = { noinline "bugpoint-crash" "no-frame-pointer-elim-non-leaf" }
----------------
Can you turn this into a positive test for the one left?


================
Comment at: tools/bugpoint/CrashDebugger.cpp:333
+  Expected<TestResult> doTest(std::vector<Attribute> &Prefix,
+                              std::vector<Attribute> &Kept) override {
+    if (!Kept.empty() && TestFuncAttrs(Kept))
----------------
It probably makes more sense to call this Suffix?


================
Comment at: tools/bugpoint/CrashDebugger.cpp:1142
+
+      if (Attrs.size() < OldSize)
+        BD.EmitProgressBitcode(BD.getProgram(), "reduced-function-attributes");
----------------
This should probably be outside the loop?  


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55216/new/

https://reviews.llvm.org/D55216