[PATCH] D55237: LTO: Don't internalize available_externally globals.
Pirama Arumuga Nainar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 3 15:33:07 PST 2018
pirama added inline comments.
================
Comment at: llvm/lib/LTO/LTO.cpp:363
+ !GlobalValue::isAppendingLinkage(S->linkage()) &&
+ S->linkage() != GlobalValue::AvailableExternallyLinkage)
S->setLinkage(GlobalValue::InternalLinkage);
----------------
Use `!GLobalValue::isAvailableExternallyLinkage(S->linkage())` instead?
Also, we should update the earlier comment.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55237/new/
https://reviews.llvm.org/D55237
More information about the llvm-commits
mailing list