[PATCH] D55233: Add objc_retain and objc_release intrinsics and codegen them to their runtime methods

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a comment.

Can you add these intrinsics to the LangRef? Seems pretty reasonable, but I don't feel comfortable LGTMing.



================
Comment at: include/llvm/IR/Intrinsics.td:324
+//
+def int_objc_retain  : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty], [Returned<0>]>;
+def int_objc_release  : Intrinsic<[], [llvm_ptr_ty]>;
----------------
I think it would be good to have these for all the entry points used by the arc optimizer, even if it isn't necessary to fix r263607. I guess it doesn't make sense to block this though, but maybe add a FIXME if you agree?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55233/new/

https://reviews.llvm.org/D55233