[PATCH] D54953: [DWARFv5] Verify all-or-nothing constraint on DIFile source

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 14:50:34 PST 2018


scott.linder added a comment.

I posted to the commit first by accident; copying here:

I realize now that this is insufficient. The other DI* metadata which have a `file:` (e.g. `DILocalVariable`) can point to an arbitrary `DIFile`, and I don't confirm that it matches the `source:` of all other files in the same `DICompileUnit`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54953/new/

https://reviews.llvm.org/D54953





More information about the llvm-commits mailing list