[PATCH] D53898: [FileCheck] Annotate input dump (6/7)

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 14:31:51 PST 2018


jdenny added a comment.

Previous feedback suggested that the description of annotations shouldn't have two lists of markers.  Seeing your confusion over `!~~`, I'm thinking maybe that suggestion was right.  It just confuses things.  What if we drop the detailed description and just have:

  - L      labels line number L of the input file
  - T:L    labels the only match result for a pattern of type T from line L of the check file
  - T:L'N  labels the Nth match result for a pattern of type T from line L of the check file
  - ^~~    marks good match (requires -v)
  - !~~    marks bad match (discarded if CHECK-DAG, or error otherwise)
  - X~~    marks search range when no match is found (success if CHECK-NOT, or error otherwise)
  - ?      marks fuzzy match when no match is found


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53898/new/

https://reviews.llvm.org/D53898





More information about the llvm-commits mailing list