[PATCH] D55149: [WebAssembly] Enforce assembler emits to streamer in order.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 12:17:45 PST 2018


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/MC/WebAssembly/assembler-binary.ll:1
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | FileCheck -check-prefix=ASM %s
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | llvm-mc -triple=wasm32-unknown-unknown -filetype=asm -o - | FileCheck -check-prefix=ASM %s
----------------
Hmm, rather than running llc twice here you could do

```
; RUN: llc -filetype=asm -asm-verbose=false %s -o %t.s
; RUN: FileCheck -check-prefix=ASM --input-file %t.s
; RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=asm %t.s -o - | FileCheck -check-prefix=ASM %s
```

Basically write the .s to a temp file and use that rather then generating and piping it twice.

I'm really not sure which is better but I thought I'd mention it as an option :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55149/new/

https://reviews.llvm.org/D55149





More information about the llvm-commits mailing list