[llvm] r348178 - [COFF] Remove an outdated/incorrect comment. NFC.
Martin Storsjo via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 3 12:02:11 PST 2018
Author: mstorsjo
Date: Mon Dec 3 12:02:11 2018
New Revision: 348178
URL: http://llvm.org/viewvc/llvm-project?rev=348178&view=rev
Log:
[COFF] Remove an outdated/incorrect comment. NFC.
Making the section writable doesn't affect how windows does
base relocs in case a DLL can't be loaded at the intended base
address.
This comment dates back to SVN r79346.
Differential Revision:
Modified:
llvm/trunk/lib/MC/MCObjectFileInfo.cpp
Modified: llvm/trunk/lib/MC/MCObjectFileInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCObjectFileInfo.cpp?rev=348178&r1=348177&r2=348178&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCObjectFileInfo.cpp (original)
+++ llvm/trunk/lib/MC/MCObjectFileInfo.cpp Mon Dec 3 12:02:11 2018
@@ -510,10 +510,6 @@ void MCObjectFileInfo::initCOFFMCObjectF
".rdata", COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | COFF::IMAGE_SCN_MEM_READ,
SectionKind::getReadOnly());
- // FIXME: We're emitting LSDA info into a readonly section on COFF, even
- // though it contains relocatable pointers. In PIC mode, this is probably a
- // big runtime hit for C++ apps. Either the contents of the LSDA need to be
- // adjusted or this should be a data section.
if (T.getArch() == Triple::x86_64) {
// On Windows 64 with SEH, the LSDA is emitted into the .xdata section
LSDASection = nullptr;
More information about the llvm-commits
mailing list