[PATCH] D55228: [PDB] Emit S_UDT records in LLD

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 11:37:36 PST 2018


zturner created this revision.
zturner added reviewers: rnk, aganea, ruiu.
Herald added a subscriber: hiraditya.

This patch emits `S_UDT` records from LLD.  These represent typedefs.  The compiler emits these into the `.debug$S` section, and the linker must split these up between the PDB globals stream and PDB module stream, depending on whether it is a global typedef or a function local typedef.

Note there is a problem here, which is that we emit local typedefs using their fully qualified name, so we append the function name to the beginning.  This is obviously wrong, and it is a simple fix, however it's orthogonal to this change so I'll submit that patch to the compiler in a followup.


https://reviews.llvm.org/D55228

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/s_udt.test
  llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55228.176438.patch
Type: text/x-patch
Size: 12166 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181203/2782a5be/attachment.bin>


More information about the llvm-commits mailing list