[PATCH] D55227: [DebugInfo] Don't drop dbg.value's of nullptr

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I have no answer for the address-space questions.   I'd say ask on llvm-dev, as it's worth asking in a more visible forum.
Assuming we are able to say that nullptr is zero for address space zero, the patch seems fine (and modifying an existing test is perfectly fine).



================
Comment at: lib/CodeGen/SelectionDAG/InstrEmitter.cpp:740
+               V->getType()->getPointerAddressSpace() == 0) {
+      // For now, assume null pointers are zero-valued
+      MIB.addImm(0);
----------------
Comment needs a full-stop at the end.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55227/new/

https://reviews.llvm.org/D55227