[PATCH] D55149: [WebAssembly] Enforce assembler emits to streamer in order.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: test/MC/WebAssembly/assembler-binary.ll:1
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | FileCheck -check-prefix=ASM %s
+; RUN: llc -filetype=asm -asm-verbose=false %s -o - | llvm-mc -triple=wasm32-unknown-unknown -filetype=asm -o - | FileCheck -check-prefix=ASM %s
----------------
aardappel wrote:
> aheejin wrote:
> > Do we need to check all these asm and yaml outputs in this test? Wouldn't yaml output of function symbol related parts be sufficient?
> Yes, but then when the yaml test breaks on e.g. the code bytes, it will be hard to track down which instruction is causing it. With the asm tests, those will break first so it will be easier to fix.
It would be awesome for obj2yaml to be able to disassemble its code section, so we could have more comprehensive binary tests that are readable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55149/new/

https://reviews.llvm.org/D55149