[PATCH] D54939: [RFC] [llvm-objcopy] Initial COFF support

Mon Dec 3 10:20:21 PST 2018

alexshap added inline comments.

================
Comment at: tools/llvm-objcopy/COFF/Object.h:30
+
+class Object;
+
----------------
mstorsjo wrote:
> jhenderson wrote:
> > To avoid confusion, maybe we should rename the ELF Object to ELFObject, and then this Object to COFFObject, etc?
> Sure, I don't mind doing that.
> 
> The same goes for D54674 and MachO as well.
> 
> Although that also moves the names closer to the class names used by llvm/Object, `COFFObjectFile` and `ELFObjectFile`, but I don't think that's an issue.
khm, i don't have a strong opinion, but they are already kinda named this way if we take into account the namespace.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54939/new/

https://reviews.llvm.org/D54939