[PATCH] D54860: [llvm-dwarfdump] - Dump the older versions of .eh_frame/.debug_frame correctly.

Mon Dec 3 09:49:25 PST 2018

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

The indentation in the test file looks a little funny; please make sure there are no hard tabs in the file.  Aside from that LGTM.

FTR, the format of .eh_frame is specified by the ELF spec, and has not been updated to reflect newer DWARF versions, that I'm aware of.  If we can get the ELF spec updated, then we wouldn't need this fussy stuff.  The format of .debug_frame of course is under the control of the DWARF spec, and so (even though it's really kind of stupid) the content does have to vary slightly depending on which section name we use.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54860/new/

https://reviews.llvm.org/D54860