[PATCH] D55187: Set norecurse attribute on functions that have debug infos.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Looks mostly good.



================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1311
   // marked norecurse, so any called from F to F will not be marked norecurse.
   for (Instruction &I : instructions(*F))
+    if (!isa<DbgInfoIntrinsic>(I))
----------------
Is there something like on the function level?

http://www.llvm.org/doxygen/classllvm_1_1BasicBlock.html#a126c95a0ff18e58ac0c2c7439fb2dc6d


================
Comment at: test/Transforms/InferFunctionAttrs/norecurse_debug.ll:53
+!21 = !{!"any pointer", !22, i64 0}
+!22 = !{!"omnipotent char", !23, i64 0}
+!23 = !{!"Simple C/C++ TBAA"}
----------------
Do you need the TBAA info for the testcase?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55187/new/

https://reviews.llvm.org/D55187