[PATCH] D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations

Mon Dec 3 08:31:31 PST 2018

ruiu added inline comments.

================
Comment at: ELF/Arch/PPC64.cpp:743
+    return isInt<26>(Offset);
+  error("Unexpected relocation type used in branch: " + Twine(Type));
+  return false;
----------------
sfertile wrote:
> inBranchRange is either called from the end of `PPC64::needsThunk` in which case the type must be either REL14 or REL24, or from the thunk creation framework which means that `PPC64::needsThunk` must have been true (and the type must have been REL14/REL24) . Because of that I think an llvm_unreachable is more appropriate than an error message.
Error messages should start with a lowercase letter.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54868/new/

https://reviews.llvm.org/D54868