[PATCH] D55210: [COFF] Remove an outdated/incorrect comment. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: rnk, ruiu, pcc.

Making the section writable doesn't affect how windows does base relocs in case a DLL can't be loaded at the intended base address.

This comment dates back to SVN r79346.


Repository:
  rL LLVM

https://reviews.llvm.org/D55210

Files:
  lib/MC/MCObjectFileInfo.cpp


Index: lib/MC/MCObjectFileInfo.cpp
===================================================================
--- lib/MC/MCObjectFileInfo.cpp
+++ lib/MC/MCObjectFileInfo.cpp
@@ -510,10 +510,6 @@
       ".rdata", COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | COFF::IMAGE_SCN_MEM_READ,
       SectionKind::getReadOnly());
 
-  // FIXME: We're emitting LSDA info into a readonly section on COFF, even
-  // though it contains relocatable pointers.  In PIC mode, this is probably a
-  // big runtime hit for C++ apps.  Either the contents of the LSDA need to be
-  // adjusted or this should be a data section.
   if (T.getArch() == Triple::x86_64) {
     // On Windows 64 with SEH, the LSDA is emitted into the .xdata section
     LSDASection = nullptr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55210.176358.patch
Type: text/x-patch
Size: 737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181203/fd2962f5/attachment.bin>