[PATCH] D55183: [gn build] Use print_function in write_cmake_config.py

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 2 14:33:01 PST 2018


thakis created this revision.
thakis added a reviewer: phosek.
Herald added a subscriber: mgorny.

No behavior change, just makes the script match the other scripts in llvm/utils/gn/build.


https://reviews.llvm.org/D55183

Files:
  llvm/utils/gn/build/write_cmake_config.py


Index: llvm/utils/gn/build/write_cmake_config.py
===================================================================
--- llvm/utils/gn/build/write_cmake_config.py
+++ llvm/utils/gn/build/write_cmake_config.py
@@ -39,6 +39,8 @@
 processing all values.
 """
 
+from __future__ import print_function
+
 import argparse
 import os
 import re
@@ -91,15 +93,15 @@
             out_lines.append(var_re.sub(repl, in_line))
 
     if unused_values:
-        print >>sys.stderr, 'Unused --values args:'
-        print >>sys.stderr, '    ', '\n    '.join(unused_values)
+        print('Unused --values args:', file=sys.stderr)
+        print('    ', '\n    '.join(unused_values), file=sys.stderr)
         return 1
 
     output = ''.join(out_lines)
 
     leftovers = var_re.findall(output)
     if leftovers:
-        print >>sys.stderr, 'unprocessed values:\n', '\n'.join(leftovers)
+        print('unprocessed values:\n', '\n'.join(leftovers), file=sys.stderr)
         return 1
 
     if not os.path.exists(args.output) or open(args.output).read() != output:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55183.176301.patch
Type: text/x-patch
Size: 1053 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181202/88700ad6/attachment.bin>


More information about the llvm-commits mailing list