[PATCH] D54882: [AMDGPU] Add sdwa support for ADD|SUB U64 decomposed Pseudos
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 2 12:02:21 PST 2018
rampitec added inline comments.
================
Comment at: lib/Target/AMDGPU/SIPeepholeSDWA.cpp:914
+ // Check if VCC is referenced in range of (MI,MISucc].
+ for (MachineBasicBlock::const_iterator I = &*std::next(MI.getIterator());
+ I != MISucc; ++I) {
----------------
Ugh.. Why do you need an interator from iterator?! This may even fail if next is end(). std::next() already returns you an iterator.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54882/new/
https://reviews.llvm.org/D54882
More information about the llvm-commits
mailing list