[PATCH] D54883: [Support/FileSystem] Use st_atimespec only when __APPLE__ is defined

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 2 11:58:43 PST 2018


thakis added a comment.

In D54883#1315925 <https://reviews.llvm.org/D54883#1315925>, @krytarowski wrote:

> In order to push this forward I recommend to:
>
> - report to Apple developers to fix this compliance nit with POSIX 2008,
> - enhance gn/bazel/any to handle detection of members in structures (it's elementary feature for a build system that intends to be portable).


(As said,the gn build shouldn't inform what LLVM does, but this is an explicit non-goal for gn, which chooses fast, predictable, and inflexible. utils/gn/README.rst's "Philosophy" section has some words on this.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54883/new/

https://reviews.llvm.org/D54883





More information about the llvm-commits mailing list