[PATCH] D53493: [DA] GPUDivergenceAnalysis for unstructured GPU kernels

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 1 03:06:43 PST 2018


nhaehnle added a comment.

In D53493#1307611 <https://reviews.llvm.org/D53493#1307611>, @simoll wrote:

> In D53493#1292733 <https://reviews.llvm.org/D53493#1292733>, @nhaehnle wrote:
>
> > LGTM. Do you need me to commit this?
>
>
> Yes, i cannot commit myself.
>
> > What are the current future plans for this whole series? I think we should enable this by default, but it would be nice to get rid of the old code, which requires addressing the irreducible test case. I vaguely recall that you mentioned a way to address that, but I can't find that now.
>
> I will open a new patch series to address the irreducibility issue. That series should also involve deprecating the LegacyDivergenceAnalysis for good.


Good, I'll be happy to switch to the new DA for good.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53493/new/

https://reviews.llvm.org/D53493





More information about the llvm-commits mailing list