[PATCH] D55141: [ValueTracking] Make unit tests easier to write; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 13:39:12 PST 2018


nikic marked 2 inline comments as done.
nikic added inline comments.


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:54
 
   void expectPattern(const SelectPatternResult &P) {
     Value *LHS, *RHS;
----------------
spatel wrote:
> This shouldn't be duplicated in the base class?
Uh, yes, it certainly shouldn't!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55141/new/

https://reviews.llvm.org/D55141





More information about the llvm-commits mailing list