[PATCH] D54912: [attributes] Add a family of OS_CONSUMED, OS_RETURNS and OS_RETURNS_RETAINED attributes
George Karpenkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 30 11:23:53 PST 2018
george.karpenkov marked an inline comment as done.
george.karpenkov added inline comments.
================
Comment at: cfe/trunk/lib/Sema/SemaDeclAttr.cpp:4862
+ case ParsedAttr::AT_OSReturnsNotRetained:
ExpectedDeclKind = ExpectedFunctionOrMethod;
break;
----------------
aaron.ballman wrote:
> I mentioned that I could fix this up in another patch, but there's a different subtlety here -- you can apply NSReturnsRetained and friends to types. See test\SemaObjC\attr-ns_returns_retained.m for an example -- where it's being added to a block type. It also seems to appertain to block literals (test\SemaObjC\block-literal-with-attribute.m).
>
> Should the OS versions also apply to types and block literals?
OS versions should not apply to block literals, neither they should be applicable to block types.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54912/new/
https://reviews.llvm.org/D54912
More information about the llvm-commits
mailing list