[PATCH] D55091: Add --analyze option to llvm-dwarfdump

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked an inline comment as done.
clayborg added a comment.

In D55091#1314914 <https://reviews.llvm.org/D55091#1314914>, @aprantl wrote:

> If we decide to consolidate all size analysis in one tool (such as llvm-objdump) that sounds good to me, too.


I still think the DWARF specific section info is good to have in --analyze output. I would rather not have to run two tools to get info on my DWARF sections if at all possible



================
Comment at: tools/llvm-dwarfdump/Analyze.cpp:71
+
+raw_ostream &operator<<(raw_ostream &OS, const ReadableFileSize &RFS) {
+  if (RFS.Size < 1024)
----------------
aprantl wrote:
> This function should go into `StringExtras.h` or `raw_ostram.h` or somewhere in Support.
ReadableFileSize is a local class. Format.h seems to be a place where ReadableFileSize could be moved of that is what you were wanting?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55091/new/

https://reviews.llvm.org/D55091