[PATCH] D55091: Add --analyze option to llvm-dwarfdump

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Thanks a lot, this will be quite useful.



================
Comment at: tools/llvm-dwarfdump/Analyze.cpp:71
+
+raw_ostream &operator<<(raw_ostream &OS, const ReadableFileSize &RFS) {
+  if (RFS.Size < 1024)
----------------
This function should go into `StringExtras.h` or `raw_ostram.h` or somewhere in Support.


================
Comment at: tools/llvm-dwarfdump/Analyze.cpp:107
+
+  // Calculate the total size of all DWARF sections
+  uint64_t TotalDwarfSize = 0;
----------------
nitpick: All comments should be full sentences and end with a `.`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55091/new/

https://reviews.llvm.org/D55091