[PATCH] D55116: [CMake] llvm_codesign polishing

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

One more note here about the `--force` parameter (which we shortly discussed in D54443 <https://reviews.llvm.org/D54443>): When using Xcode for testing multi-config generators, I run into double signing issues. I didn't investigate in detail yet, but I am slightly in favor of hardcoding it in the codesign invocation now.
Is it possible that Xcode runs PostBuild even if it did not actually regenerate the binary? With Ninja all goes well.

  Link /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen
  Run custom shell script 'CMake PostBuild Rules'
    xcrun dsymutil /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen
    warning: no debug symbols in executable (-arch x86_64)
    /.../usr/bin/strip -Sxl /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen
    /.../usr/bin/strip: changes being made to the file will invalidate the code signature in: /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen
    /.../usr/local/bin/cmake -E env CODESIGN_ALLOCATE=/.../usr/bin/codesign_allocate xcrun codesign -s lldb_codesign /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen /path/to/xcode/RelWithDebInfo/bin/llvm-tblgen: is already signed
    make: *** [llvm-tblgen_buildpart_1] Error 1
    Command /bin/sh failed with exit code 2


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55116/new/

https://reviews.llvm.org/D55116