[PATCH] D55113: [llvm-dwarfdump] - Stop printing the bogus empty section name on invalid dwarf.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 30 07:50:57 PST 2018

Previous message: [PATCH] D55113: [llvm-dwarfdump] - Stop printing the bogus empty section name on invalid dwarf.
Next message: [PATCH] D55065: [clangd] Drop injected class name when class scope is not explicitly specified.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

probinson added a comment.

Are those hard tabs in the test .s file?  many editors do that automatically in assembler source, but the LLVM project doesn't want hard tabs.

LGTM otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55113/new/

https://reviews.llvm.org/D55113

Previous message: [PATCH] D55113: [llvm-dwarfdump] - Stop printing the bogus empty section name on invalid dwarf.
Next message: [PATCH] D55065: [clangd] Drop injected class name when class scope is not explicitly specified.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list