[PATCH] D54963: [lit] Pass more environment variables through on Windows

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D54963#1310190 <https://reviews.llvm.org/D54963#1310190>, @zturner wrote:

> I don't think that ever actually happened, or at least I never observed it.  The real behavior change is that we're now passing through "LIB", "VCINSTALLDIR", "VCToolsInstallDir", "VSINSTALLDIR", "WindowsSdkDir", and "WindowsSdkVersion", whereas before we were not propagating them into the child environment at all.  clang-cl reads these, so it could have an observable impact on clang-cl (but any observable impact should be beneficial, since before it would actually just fail if a test tried to include a system header or link against a system library)


At least for clang tests, tests reading system libraries are usually a bug -- tests are supposed to be hermetic, cross-platform, etc. It sounds like now it's easier to accidentally use a system header?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54963/new/

https://reviews.llvm.org/D54963