[PATCH] D21552: [llvm-readobj] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/trunk/tools/llvm-readobj/ELFDumper.cpp:569
+      report_fatal_error("at least one definition string must exist");
+    if (VD->vd_cnt > 2)
+      report_fatal_error("more than one predecessor is not expected");
----------------
Higuoxing wrote:
> Higuoxing wrote:
> > Higuoxing wrote:
> > > Hi, I am curious about why the Parents/Predecessor more than one. According to https://akkadia.org/drepper/symbol-versioning 
> > > 
> > > >  `vda_next` byte offset to the next Elfxx_Verdaux entry.  The first entry (pointed to by the Elfxx_Verdef entry, contains the actual defined name.  The second and all later entries name predecessor versions.
> > > 
> > > Feel free to ignore me :) just out of curiosity
> > Besides, `gnu-readelf` could print multiple parents
> Sorry, I am curious about why the Parents/Predecessor *cannot be* more than one.
> 
> You could use my patch to make a simple test, if needed
> 
> https://reviews.llvm.org/D54867
> 
> feel free to ignore me :)
Hi! You can find some answers in the comments for this patch, starting from this one:
https://reviews.llvm.org/D21552?id=61354#inline-182645

In short - I was unable to produce the output that has more than one predecessor,
so having the code for that was unuseful and we stopped on this version of code that time.
It still seems reasonable nowadays, I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D21552/new/

https://reviews.llvm.org/D21552