[PATCH] D55009: [GVN] Don't perform scalar PRE on GEPs
Alexandros Lamprineas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 30 03:50:04 PST 2018
labrinea added a comment.
In D55009#1311601 <https://reviews.llvm.org/D55009#1311601>, @john.brawn wrote:
> It may be worthwhile allowing scalar PRE on GEPs that we know won't be combined into the addressing mode of a load/store, i.e. those where TargetTransformInfo::isLegalAddressingMode returns false.
That would require to run the Target IR Analysis before GVN. It would also require an Address Mode Matcher like the one CodeGenPrepare implements. It doesn't seem worthwhile to me unless there's another way I haven't thought about.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55009/new/
https://reviews.llvm.org/D55009
More information about the llvm-commits
mailing list