[PATCH] D54621: [ELF] - Do not remove empty sections referenced in LOADADDR/ADDR commands.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D54621#1314195 <https://reviews.llvm.org/D54621#1314195>, @peter.smith wrote:

> For this particular example, I don't think it is necessary to keep the .empty section in the ELF file; however I think that it is important for the calculation of the addresses of .text and .data to be either correct or we give an error message. It may be that forcibly keeping .empty is the easiest way of achieving that. An error message is not particularly friendly but it would at least alert the user that they would need to add zero sized sections or symbols to make sure the section was kept.


Thanks, Peter! I suddenly noticed that seems it would be not hard to report an error instead. I'll try to prepare the alternative patch doing that to check what is needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54621/new/

https://reviews.llvm.org/D54621