[PATCH] D54837: [Sanitizer] getentropy interception

[David CARLIER via Phabricator via llvm-commits]

devnexen marked an inline comment as done.
devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:170
+  // possible issue.
+  return internal_syscall(SYSCALL(getrandom), buffer,
+           length, 0);
----------------
vitalybuka wrote:
> so here syscall is used when we have "check_library_exists(c getentropy"
> which does not looks right.
> I'd recommend just to update existing hardcoded  "# define SANITIZER_USE_GETENTROPY 1"
The problem is the nolibc's case and getentropy is "just" a C wrapper around getrandom .


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54837/new/

https://reviews.llvm.org/D54837