[PATCH] D54925: [NFC] [PowerPC] add an routine in PPCTargetLowering to determine if a global is accessed as got-indirect or not.

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 23:01:52 PST 2018


steven.zhang added a comment.

Update the comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:793
+    // Returns true if the address of the global is stored in TOC entry.
+    bool isAccessedAsTOCIndirect(SDValue N) const;
+
----------------
sfertile wrote:
> I would prefer to keep consistent with the V2 abi naming and call this 'GotIndirect' instead of TOCIndirect, but don't feel super strongly about it.
I was swing between these two terms. Agree that Got would be more clear. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54925/new/

https://reviews.llvm.org/D54925





More information about the llvm-commits mailing list