[PATCH] D54987: Add interceptors for the sha2(3) from NetBSD
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 29 17:37:02 PST 2018
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7420
+ return ret; \
+ }
+
----------------
```
#define INIT_SHA2_INTECEPTORS(LEN) \
COMMON_INTERCEPT_FUNCTION(SHA##LEN##_Init); \
...
COMMON_INTERCEPT_FUNCTION(SHA##LEN##_Data); \
#define INIT_SHA2 \
INIT_SHA2_INTECEPTORS(224); \
INIT_SHA2_INTECEPTORS(256); \
INIT_SHA2_INTECEPTORS(384); \
INIT_SHA2_INTECEPTORS(512);
```
================
Comment at: test/sanitizer_common/TestCases/NetBSD/sha224.cc:1
+// RUN: %clangxx -O0 -g %s -o %t && %run %t 2>&1 | FileCheck %s
+
----------------
tests are very similar. can you just use multiple:
```
RUN: .. -DSSH_SIZE=224..
RUN: .. -DSSH_SIZE=256..
RUN: .. -DSSH_SIZE=384..
```
================
Comment at: test/sanitizer_common/TestCases/NetBSD/sha256.cc:144
+ // CHECK: test1:
+ // 'bb000ddd92a0a2a346f0b531f278af06e370f86932ccafccc892d68d350f80f8' CHECK:
+ // test2: 'bb000ddd92a0a2a346f0b531f278af06e370f86932ccafccc892d68d350f80f8'
----------------
tests are broken by clang-format
please protect such lines with
// clang-format off
// clang-format on
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54987/new/
https://reviews.llvm.org/D54987
More information about the llvm-commits
mailing list