[PATCH] D53794: [TargetLowering] expandFP_TO_UINT - avoid FPE due to out of range conversion (PR17686)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:4192
+    // Expand based on maximum range of FP_TO_SINT, if the value exceeds the
+    // signmask then offset (f32/f64 results should then be whole integers).
+    // Sel = Src < 0x8000000000000000
----------------
> f32/f64 results should then be whole integers

I'm not sure what this means; are you saying the result of the subtraction a whole integer?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53794/new/

https://reviews.llvm.org/D53794