[PATCH] D54954: [DAGCombiner] guard against an oversized shift crash

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 15:47:09 PST 2018


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6105
+      // shift has been simplified to undef.
+      unsigned ShiftAmt = ShiftC->getZExtValue();
+      if (ShiftAmt < BitWidth) {
----------------
I think you need to use getLimitedValue() here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54954/new/

https://reviews.llvm.org/D54954





More information about the llvm-commits mailing list