[PATCH] D55014: Add a new interceptor for getvfsstat(2) from NetBSD

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 15:25:53 PST 2018


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/sanitizer_common/TestCases/NetBSD/getvfsstat.cc:15
+  struct statvfs *buf;
+  printf("getvfsstat\n");
+
----------------
could you please declare vars were they used first time?


================
Comment at: test/sanitizer_common/TestCases/NetBSD/getvfsstat.cc:18
+  if ((rv = getvfsstat(NULL, 0, ST_WAIT)) == -1)
+    err(EXIT_FAILURE, "getvfsstat");
+
----------------
you can simplify the test with simple asserts here


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55014/new/

https://reviews.llvm.org/D55014





More information about the llvm-commits mailing list