[PATCH] D55059: [ARM] FP16: constant initialised v4f16 and v8f16 vectors

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The lib/Target/ARM/ARMInstrNEON.td look like they belong in a separate patch.  And it looks like there isn't any explicit test coverage of bitcasts.

Please clean up the testcase so it only contains the relevant operations; the whole loop isn't necessary.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:5744
   // of a zero vector, and the default encoding of zero is supposed to be the
-  // 32-bit version.
+  // 32-bit version, and the 16-bit version for f16 vectors.
   if (SplatBits == 0)
----------------
Why does this matter?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55059/new/

https://reviews.llvm.org/D55059