[PATCH] D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes

[Volkan Keles via Phabricator via llvm-commits]

volkan added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-nonpowerof2eltsvec.mir:42
+    %6(s64) = G_EXTRACT_VECTOR_ELT %1(<3 x s64>), %3(s64)
+    %7(s64) = G_EXTRACT_VECTOR_ELT %1(<3 x s64>), %4(s64)
+    $x0 = COPY %6(s64)
----------------
aemerson wrote:
> volkan wrote:
> > This test fails because G_EXTRACT_VECTOR_ELT for v3s64 is not legal. Could you fix that?
> This test doesn't seem to do what it says on the tin. It actually never tested any legalizing, commit r299929 introduced it but as far as I can tell, the G_UNMERGE is deleted due to the legalizercombiner, and G_MERGE here is specified as legal by AArch64 so the legalizer never did anything.
> 
> I propose deleting this test as it doesn't seem to achieve anything at the moment.
I added this test to make sure we don't hit the assertion when legalizing non-power-of-2 types. I think it is okay to remove it as there are already tests with non-power-of-2 types.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53629/new/

https://reviews.llvm.org/D53629