[PATCH] D55073: [SelectionDAG] Split very large token factors for loads into 64k chunks

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1052
+    Root =
+        DAG.getNode(ISD::TokenFactor, getCurSDLoc(), MVT::Other, TokenFactors);
+  }
----------------
Instead of making a tree of TokenFactors, could you make a list?  It seems a little simpler (less code, and you don't have to worry about the length of TokenFactors itself).

I'm a little worried that other code dealing with TokenFactors might end up violating the limit if we're very close... any idea if there's other code that could be affected, like DAGCombine?  Do we have an assertion somewhere that will reliably catch this issue?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55073/new/

https://reviews.llvm.org/D55073