[PATCH] D55071: [AMDGPU] Split 64-Bit XNOR to 64-Bit NOT/XOR
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 29 14:21:39 PST 2018
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:4908
+ MachineOperand &Src1 = Inst.getOperand(2);
+ DebugLoc DL = Inst.getDebugLoc();
+
----------------
grahamsellers wrote:
> arsenm wrote:
> > const reference
> I stole this from elsewhere in this file. I went ahead and fixed other places where this was not const reference.
The guidance used to be to use values, but then that changed at some point but nobody ever went back and changed them all
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55071/new/
https://reviews.llvm.org/D55071
More information about the llvm-commits
mailing list